Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs): permissions #111

Closed
wants to merge 2 commits into from

Conversation

ragnarpa
Copy link

@ragnarpa ragnarpa commented Mar 3, 2024

No description provided.

@gr2m
Copy link
Contributor

gr2m commented Mar 3, 2024

We don't want to implement permissions as a single object, but as separate keys, as described here: #3

We want these keys to be automatically kept up to date based on new releases of https://github.com/octokit/app-permissions, which we can implement via actions and https://github.com/apps/octokit-release-notifier

@ragnarpa
Copy link
Author

ragnarpa commented Mar 4, 2024

We don't want to implement permissions as a single object, but as separate keys, as described here: #3

We want these keys to be automatically kept up to date based on new releases of https://github.com/octokit/app-permissions, which we can implement via actions and https://github.com/apps/octokit-release-notifier

@gr2m, when can we expect #3 to be released?

@gr2m
Copy link
Contributor

gr2m commented Mar 4, 2024

we should be unblocked since https://github.com/octokit/app-permissions/releases/tag/v2.0.0

@martincostello
Copy link
Contributor

Any chance on this being released soon if it's unblocked? I'd like to consume the changes to move into this action from a third-party one.

@gr2m
Copy link
Contributor

gr2m commented Apr 25, 2024

sorry we have been busy with other projects, I cannot give you an ETA when we get to finish up this work. The current pull request cannot be merged as is, my concerns from above (#111 (comment)) have not been addressed yet. We don't want a single permissions parameter, but separate permission_{permission_name} keys, e.g. permission_issues. And we want these to be auto-generated based on https://github.com/octokit/app-permissions/

@ragnarpa
Copy link
Author

Hi all. Sorry, but I do not have enough resources to address the aforementioned concerns in this pull request. As this pull won't me merged as it is then I'll close it.

@ragnarpa ragnarpa closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants