Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to hide the inputs in the first step of the workflow_call job #2988

Open
arununzer opened this issue Nov 15, 2023 · 5 comments
Open
Labels
bug Something isn't working

Comments

@arununzer
Copy link

arununzer commented Nov 15, 2023

Describe the bug
A clear and concise description of what the bug is.

Unable to hide the inputs in the first step of the workflow_call job

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Actions tab after building a sample workflow call job - reusable workflow'
  2. Run 'the sample action'
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.

able to hide the inputs in the first step of the workflow_call job

Runner Version and Platform

Version of your runner?
2.311.0

OS of the machine running the runner? OSX/Windows/Linux/...
ubuntu 22.04 self hosted runner

What's not working?

Please include error messages and screenshots.
Screenshot (4)

Job Log Output

Runner and Worker's Diagnostic Logs

 Inputs
    CostCenter: 10000
    LegalEntity: GmbH
    Project: Infra
    Team: Platform Engineering
    env: int
    secret_name: infra/arun-test2
    secret_value: user=arun,pass=wi;hf&0(^%$!d@YLn7
@arununzer arununzer added the bug Something isn't working label Nov 15, 2023
@arununzer arununzer changed the title Unable to hide the inputs in the first step of the workflow_dispatch job Unable to hide the inputs in the first step of the workflow_call job Nov 15, 2023
@arununzer
Copy link
Author

Any update on this as its quite urgent .. Thanks :)

@rgrygorovych
Copy link

rgrygorovych commented Feb 7, 2024

Same issue, even using the reusable actions from marketplace not working:

`
Mask-Secrets:
name: Mask secret ${{ inputs.name }}
runs-on: ubuntu-latest

steps:
  - name: Hide the inputs values to keep them private in the logs when running this workflow
    uses: levibostian/action-hide-sensitive-inputs@v1
    with:
      exclude_inputs: operation, name, aws_region, environment, product

`

However, this action does the job in other cases, in not reusable workflows.

@rgrygorovych
Copy link

rgrygorovych commented Feb 7, 2024

@arununzer check your password leakage
secret_value: user=arun,pass=wi;h***********

;)

@rgrygorovych
Copy link

btw, levibostian/action-hide-sensitive-inputs is only properly working with workflow_dispatch and not workflow_call :(

@tateexon
Copy link

This definitely needs fixed. We have secrets that would get shown because of this. Been working around it with actions for a long time now. It just muddies the reusability across repos and opens up a lot of copy paste that can cause errors and is a lot to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants