Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions cache does not actually work #3316

Open
davhdavh opened this issue Jun 6, 2024 · 1 comment · May be fixed by #3317
Open

Actions cache does not actually work #3316

davhdavh opened this issue Jun 6, 2024 · 1 comment · May be fixed by #3317
Labels
bug Something isn't working

Comments

@davhdavh
Copy link

davhdavh commented Jun 6, 2024

Describe the bug

case WellKnownDirectory.Actions:
path = Path.Combine(
GetDirectory(WellKnownDirectory.Work),
Constants.Path.ActionsDirectory);

Specifies that the actions cache is a subfolder of the work folder, but the work folder is always totally reset.

To Reproduce
Steps to reproduce the behavior:

  1. Run a workflow that uses any action -> observe in the "Set up Job" part of the run that it downloads the action(s)
    (ie, the text from
    executionContext.Output($"Download action repository '{downloadInfo.NameWithOwner}@{downloadInfo.Ref}' (SHA:{downloadInfo.ResolvedSha})");
    )
  2. Run same work -> observe in the "Set up Job" part of the run that it downloads the action(s)

Expected behavior

  1. same
  2. Action is already downloaded -> ie, the text from
    executionContext.Debug($"Action '{downloadInfo.NameWithOwner}@{downloadInfo.Ref}' already downloaded at '{destDirectory}'.");

Runner Version and Platform

latest, any os

Job Log Output

Download action repository 'actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808' (SHA:65462800fd760344b1a7b4382951275a0abb4808)

Suggested fix:

GetDirectory(WellKnownDirectory.Work),

Change to .Tools instead of .Work

@davhdavh davhdavh added the bug Something isn't working label Jun 6, 2024
davhdavh added a commit to davhdavh/runner that referenced this issue Jun 6, 2024
@davhdavh
Copy link
Author

Anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant