Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log "Kill entire process tree" does not match actual behavior #3341

Open
carlcsaposs-canonical opened this issue Jun 17, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@carlcsaposs-canonical
Copy link

I have no experience with .NET, so I apologize if I am misunderstanding and this is not a bug

Describe the bug
The log "Kill entire process tree..."

Trace.Info("Kill entire process tree since both cancel and terminate signal has been ignored by the target process.");

does not match the actual behavior of the runner:

.Kill(), from my understanding, only kills that process. It does not kill children processes. To kill the entire process tree, use .Kill(true)

To Reproduce
Look at source code or run job with

steps:
   - run: sleep 360
     timeout-minutes: 1

and look at logs in ~/actions-runner/_diag/Worker_*.log

Expected behavior
Log says "Kill process" instead of "Kill entire process tree"

Runner Version and Platform

Version of your runner? v2.317.0

OS of the machine running the runner? Ubuntu 22.04

What's not working?

Log says "Kill entire process tree"

@carlcsaposs-canonical carlcsaposs-canonical added the bug Something isn't working label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant