feat: Add basic support for .msi files appended to an executable

Author: learn-more

src/LessMsi.Core/Msi/MsiDatabase.cs

@@ -23,6 +23,9 @@
 //	Scott Willeke ([email protected])
 //
 using Microsoft.Tools.WindowsInstallerXml.Msi;
+using System;
+using System.IO;
+using System.IO.MemoryMappedFiles;
 
 namespace LessMsi.Msi
 {
@@ -53,5 +56,82 @@ public static Database Create(LessIO.Path msiDatabaseFilePath)
 				return new Database(msiDatabaseFilePath.PathString, OpenDatabase.ReadOnly | (OpenDatabase)MSIDBOPEN_PATCHFILE);
 			}
 		}
+
+
+		static readonly Byte[] STORAGE_magic = new byte[]{ 0xd0, 0xcf, 0x11, 0xe0, 0xa1, 0xb1, 0x1a, 0xe1 };
+
+		public static bool TryDetectMsiHeader(LessIO.Path filePath, out long offset)
+		{
+			using (var mapped = MemoryMappedFile.CreateFromFile(filePath.PathString, System.IO.FileMode.Open, null, 0L, MemoryMappedFileAccess.ReadWrite))
+			{
+				using (var accessor = mapped.CreateViewAccessor(0, 0, MemoryMappedFileAccess.Read))
+				{
+					byte[] buffer = new byte[4096];
+					long readOffset = 0;
+					while (true)
+					{
+						var totalRemaining = accessor.Capacity - readOffset;
+						if (totalRemaining <= 0)
+							break;
+						int remaining = accessor.ReadArray(readOffset, buffer, 0, (int)Math.Min(totalRemaining, buffer.Length));
+						if (remaining <= 0)
+							break;
+
+						bool moveLess = false;
+						for (int n = 0; n < remaining; n++)
+						{
+							if (buffer[n] == STORAGE_magic[0])
+							{
+								if (buffer.Length - n >= STORAGE_magic.Length)
+								{
+									bool match = true;
+									for (int m = 1; m < STORAGE_magic.Length; m++)
+									{
+										if (buffer[n + m] != STORAGE_magic[m])
+										{
+											match = false;
+											break;
+										}
+									}
+									if (match)
+									{
+										offset = readOffset + n;
+										return true;
+									}
+								}
+								else
+								{
+									moveLess = true;
+									break;
+								}
+							}
+						}
+
+						if (moveLess && remaining > STORAGE_magic.Length && readOffset > STORAGE_magic.Length)
+						{
+							readOffset -= STORAGE_magic.Length;
+						}
+						readOffset += remaining;
+					}
+
+					offset = -1;
+					return false;
+				}
+			}
+		}
+
+		public static void ExtractMsiFromExe(LessIO.Path filePath, LessIO.Path outputFile, long offset)
+		{
+			using (var mapped = MemoryMappedFile.CreateFromFile(filePath.PathString, FileMode.Open, null, 0L, MemoryMappedFileAccess.ReadWrite))
+			{
+				using (var reader = mapped.CreateViewStream(offset, 0, MemoryMappedFileAccess.Read))
+				{
+					using (var output = File.Create(outputFile.PathString))
+					{
+						reader.CopyTo(output);
+					}
+				}
+			}
+		}
 	}
 }

src/LessMsi.Gui/IMainFormView.cs

@@ -77,6 +77,8 @@ internal interface IMainFormView
 		/// Shows an error to the user.
 		/// </summary>
 		void ShowUserError(string formatStr, params object[] args);
+
+        bool ShowUserMessageQuestionYesNo(string message);
         /// <summary>
         /// Adds a column to the MSI table grid.
         /// </summary>

src/LessMsi.Gui/MainForm.cs

@@ -54,7 +54,7 @@ internal class MainForm : Form, IMainFormView
         private Panel pnlStreamsBottom;
         private Button btnExtractStreamFiles;
         private ToolStripMenuItem searchFileToolStripMenuItem;
-        readonly static string[] AllowedDragDropExtensions = new[] { ".msi", ".msp" };
+        readonly static string[] AllowedDragDropExtensions = new[] { ".msi", ".msp", ".exe" };
 
         public MainForm(string defaultInputFile)
         {
@@ -169,6 +169,12 @@ public void ShowUserError(string formatStr, params object[] args)
             ShowUserMessageBox(string.Format(CultureInfo.CurrentUICulture, formatStr, args));
         }
 
+        public bool ShowUserMessageQuestionYesNo(string message)
+        {
+            return MessageBox.Show(this, message, "LessMSI", MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes;
+        }
+
+
         #region MSI Table Grid Stuff
 
         public void AddTableViewGridColumn(string headerText)

src/LessMsi.Gui/MainFormPresenter.cs

@@ -22,19 +22,20 @@
 // Authors:
 //	Scott Willeke ([email protected])
 //
-using System;
-using System.Collections.Generic;
-using System.ComponentModel;
-using System.Diagnostics;
-using System.IO;
-using System.Linq;
 using LessIO;
 using LessMsi.Gui.Model;
 using LessMsi.Gui.Resources.Languages;
 using LessMsi.Gui.Windows.Forms;
 using LessMsi.Msi;
 using LessMsi.OleStorage;
 using Microsoft.Tools.WindowsInstallerXml.Msi;
+using System;
+using System.Collections.Generic;
+using System.ComponentModel;
+using System.Diagnostics;
+using System.IO;
+using System.IO.MemoryMappedFiles;
+using System.Linq;
 
 namespace LessMsi.Gui
 {
@@ -545,6 +546,16 @@ public void LoadCurrentFile()
 			}
 			catch (Exception eCatchAll)
 			{
+				if (eCatchAll is IOException && this.SelectedMsiFile.Extension.ToLower() == ".exe" && MsiDatabase.TryDetectMsiHeader(new LessIO.Path(this.SelectedMsiFile.FullName), out long offset))
+				{
+					if (View.ShowUserMessageQuestionYesNo("It looks like this file contains a .msi file, do you want to extract it?"))
+					{
+						var tempFile = System.IO.Path.GetTempFileName();
+						MsiDatabase.ExtractMsiFromExe(new LessIO.Path(this.SelectedMsiFile.FullName), new LessIO.Path(tempFile), offset);
+						LoadFile(tempFile);
+						return;
+					}
+				}
 				isBadFile = true;
 				Error(Strings.OpenFileError, eCatchAll);
 			}

src/Lessmsi.Tests/MiscTests.cs

@@ -139,6 +139,25 @@ public void MissingStreamsTable()
         public void MissingParentDirectoryEntry()
         {
             ExtractAndCompareToMaster("IviNetSharedComponents32_Fx20_1.3.0.msi");
+        }
+
+        /// <summary>
+        /// From https://github.com/activescott/lessmsi/pull/237
+        /// </summary>
+        [Fact]
+        public void TryDetectEmbeddedMsi()
+        {
+            bool containsMsi = Msi.MsiDatabase.TryDetectMsiHeader(GetMsiTestFile("vmware_tools_setup.exe"), out long offset);
+            Assert.True(containsMsi);
+            Assert.Equal(0x315E3C, offset);
+
+            containsMsi = Msi.MsiDatabase.TryDetectMsiHeader(GetMsiTestFile("IviNetSharedComponents32_Fx20_1.3.0.msi"), out offset);
+            Assert.True(containsMsi);
+            Assert.Equal(0, offset);
+
+            containsMsi = Msi.MsiDatabase.TryDetectMsiHeader(GetMsiTestFile("msi_with_external_cab.cab"), out offset);
+            Assert.False(containsMsi);
+            Assert.Equal(-1, offset);
         }
     }
 }