Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State management review #26

Open
zuzust opened this issue Feb 28, 2017 · 2 comments
Open

State management review #26

zuzust opened this issue Feb 28, 2017 · 2 comments
Assignees
Milestone

Comments

@zuzust
Copy link
Member

zuzust commented Feb 28, 2017

Make sure ngrx/store patterns are applied the right way. If not, refactor accordingly.

@zuzust zuzust added the chore label Feb 28, 2017
@zuzust zuzust added this to the Iteration #2 milestone Feb 28, 2017
@zuzust zuzust self-assigned this Feb 28, 2017
@zuzust zuzust removed the chore label Feb 28, 2017
@plastikaweb
Copy link
Contributor

plastikaweb commented Mar 1, 2017

Implementations like the actual one:

I assume this would be more elegant:
In app.module.ts
StoreModule.provideStore({ currentSearch: CurrentSearchReducer })
In xxx.component.ts
constructor(private store: Store<any>) { this.store.select('currentSearch') .subscribe((data) => { ... }); }

Some interesting literature for a better ngrx structure:

@zuzust zuzust assigned adabits and unassigned adabits Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants