Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename template upload/download to R503 specific #31

Open
admiralmaggie opened this issue Mar 13, 2021 · 2 comments
Open

Rename template upload/download to R503 specific #31

admiralmaggie opened this issue Mar 13, 2021 · 2 comments

Comments

@admiralmaggie
Copy link

@jerryneedell I finally got a chance to test the optical sensors. I got two different models:

https://www.adafruit.com/product/4690
and
https://www.adafruit.com/product/751

image

As you suspected, the LED method is causing issues with these two units. The good thing is the template upload/download does work but there is a wierd extra packet being sent by these two modules when asked to compare two template (instruction 03x):

*** DEBUG ==> _send_packet data: ['ef', '01', 'ff', 'ff', 'ff', 'ff', '01', '00', '03', '03', '00', '07']   
*** DEBUG ==> _get_packet received data: ['ef', '01', 'ff', 'ff', 'ff', 'ff', '07', '00', '03', '01', '00', '0b']  <<=== Failure packet
*** DEBUG ==> _get_packet reply: ['01']  
*** DEBUG ==> _get_packet received data: ['ef', '01', 'ff', 'ff', 'ff', 'ff', '07', '00', '05', '00', '00', 'ff', '01', '0b']  <<=== Followed by proper expected packet
*** DEBUG ==> _get_packet reply: ['00', '00', 'ff']  
*** DEBUG ==> compare_templates confidence: (255,)  
Fingerprint match template in file.   

It sends error when receiving package (01x) followed by a proper/expected packet. It does not appear to affect the functionality.

I guess The easiest thing to do is to create PR and rename the template upload/down example to R503 specific. We can just document what needs to be done to make the example work with non R503 sensors.

@jerryneedell
Copy link
Contributor

It appears that the "soft_reset" command is also only available for the R503.
Not sure how best to handle the differences.

@admiralmaggie
Copy link
Author

@jerryneedell I guess we could make the sensor type a parameter in the constructor method (called type=) and derive what is supported from there. Something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants