Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String internationalization for Spanish. #1094

Closed
C47D opened this issue Aug 7, 2018 · 9 comments
Closed

String internationalization for Spanish. #1094

C47D opened this issue Aug 7, 2018 · 9 comments

Comments

@C47D
Copy link
Collaborator

C47D commented Aug 7, 2018

Hi,

My name is Carlos and i will be working on the internationalization of strings for the Spanish language, this is my first contribution so bear with me, any help is welcome!

@ladyada
Copy link
Member

ladyada commented Aug 7, 2018

welcome! :)

@arofarn
Copy link

arofarn commented Aug 12, 2018

Hi,

I'm Pierrick from France. Same for french languages : first contribution!

@tannewt
Copy link
Member

tannewt commented Aug 13, 2018

Great @arofarn! Please file a separate issue for French. Let me know if you have any questions. Thanks!

@tannewt tannewt added the Hacktoberfest Beginner friendly issues for Hacktoberfest event label Oct 1, 2018
@yeyeto2788
Copy link

@C47D is there anything I can help with the translation into Spanish? As far as I saw in the file there are some string pending to translate.

Let me know and we can work together on it.

Regards.

@C47D
Copy link
Collaborator Author

C47D commented Nov 25, 2018

Hi @yeyeto2788, i had been busy with work and as you already noticed there are some not translated or not updated strings, so feel free to send a pull request and me or @sabas1080 can review it.

Gracias por la ayuda!

@yeyeto2788
Copy link

Sorry guys for the late reply, I'll fork the repo to make the changes and then I'll ask for the PR.

Regards.

@yeyeto2788
Copy link

Hello guys! happy to announce that I have done the first PR #1364 I hope it is ok.

There are some things that I wondered while I was translating, I'll list them down here to see what you think.

  • There are some typos in english, should I fix them also?

  • If I fix a typo in English I guess that it has to be also fixed on the code in order to match the msgid, right?

  • Regarding words like (int, tuple, list, etc) for me it is ok to have something like this int (entero).
    Notice that I keep the English word and add the translation for it. What should I do? Right now on the PR you'll see that I have done it for other words but not for the ones listes above.

Please do not hesitate on letting me know what are your thoughts on this.

Regards.

@dhalbert
Copy link
Collaborator

Sure, please fix any English typos as well, and yes, you'll need to find the original location and fix that.

Adding things like int (entero) is probably not necessary, since a user has to know the original vocabulary in order to use the language. When in doubt, it's good to be more concise than verbose, since we have limited flash space, especially on M0 boards.

@yeyeto2788
Copy link

yeyeto2788 commented Nov 29, 2018

@dhalbert thanks for the info.

I'll check again for those typos and keep in mind about flash space.

Is it possible to check the percentage of strings translated somewhere?

@tannewt tannewt modified the milestones: 4.0.0 - Bluetooth, Long term Mar 27, 2019
@adafruit-adabot adafruit-adabot removed the Hacktoberfest Beginner friendly issues for Hacktoberfest event label Nov 2, 2019
@tannewt tannewt closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants