Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likely color inversion between red and blue in snxrom #2

Open
dglaude opened this issue Sep 24, 2023 · 1 comment · May be fixed by #3
Open

Likely color inversion between red and blue in snxrom #2

dglaude opened this issue Sep 24, 2023 · 1 comment · May be fixed by #3

Comments

@dglaude
Copy link
Contributor

dglaude commented Sep 24, 2023

I compared the result of this snxrom from @jepler and the old ruxalyzer from @ladyada and there seems to be an inversion in the red and blue color in reading the bin file.

Left is this tool, right is the legacy tool and matching the Teddy blue eyes:
image

I have not really located where the conversion take place in this code, and if there is one or two places where it take place (for conversion in one direction and/or the other).

No time right now to fix it, but I could try.
@ladyada
Copy link
Member

ladyada commented Sep 24, 2023

we are not likely to work on this project anymore, feel free to PR any changes or fixes.

@dglaude dglaude linked a pull request Sep 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the Red/Blue inversion while reading. dglaude/snxrom
2 participants
@ladyada @dglaude