Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_editorPathSuffix behaves inconsistently across all Platforms #64

Open
sleeptightAnsiC opened this issue Mar 15, 2024 · 0 comments
Open

Comments

@sleeptightAnsiC
Copy link
Contributor

Hi Adam,

Is there a reason for _editorPathSuffix taking cmdVersion parameter into consideration only on Windows?
I can see those executable variations on Linux (screenshot below).
I'm not sure how these executables work and if they're also supported on MacOS and on Installed builds.
Anyway, should be pretty easy to fix. I can quickly change it. Let me know what do you think.

image

def _editorPathSuffix(self, cmdVersion):
return '-Cmd.exe' if cmdVersion == True else '.exe'

def _editorPathSuffix(self, cmdVersion):
version = parse_version(self.getEngineVersion())
if version < parse_version('5.0.0'):
return '.app/Contents/MacOS/UE4Editor'
else:
return '.app/Contents/MacOS/UnrealEditor'

def _editorPathSuffix(self, cmdVersion):
return ''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant