Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier logic allows events from other players to be matched #22

Open
adamus1red opened this issue Jun 5, 2021 · 0 comments
Open

Modifier logic allows events from other players to be matched #22

adamus1red opened this issue Jun 5, 2021 · 0 comments
Labels

Comments

@adamus1red
Copy link
Owner

Looks like this issue is caused by the pattern match just looking for case of $username anywhere in the modifiers string.
See https://idlerpg.lolhosting.net/playerview.php?player=Covid-19 for example

Image of Bug

Seems the issue stems from this lovely bit of hell code

while ($line=fgets($file,1024)) {
if (strstr($line," ".$_GET['player']." ") ||
strstr($line," ".$_GET['player'].", ") ||
substr($line,0,strlen($_GET['player'])+1) ==
$_GET['player']." " ||
substr($line,0,strlen($_GET['player'])+3) ==
$_GET['player']."'s ") {
array_push($temp,$line);
}
}

@adamus1red adamus1red added the bug label Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant