Subject of the enhancement
Currently in the Hot Graphic popups, the Previous and Next buttons' aria-labels change when the button is disabled. For example, the Previous button's aria-label is simply "Previous" rather than "Previous (item 2 of 3)" when the first item is active. When _canCycleThroughPagination is true, though, the buttons are never disabled so this pattern does not apply.
Consider reworking the Hot Graphic popup aria labels for Previous and Next to more closely align with Narrative. adaptlearning/adapt-contrib-narrative#311
For the Previous button, instead of relying on the presence of a title property for determining when we're at the beginning, we would rely on the _isAtStart property. Likewise, for the Next button, we would rely on _isAtEnd.
We would also need to account for when the items can be looped through when _canCycleThroughPagination is true. Narratives do not offer this option. So, it's possible that this rework is not necessary or should be adjusted to accommodate looping.
Subject of the enhancement
Currently in the Hot Graphic popups, the Previous and Next buttons' aria-labels change when the button is disabled. For example, the Previous button's aria-label is simply "Previous" rather than "Previous (item 2 of 3)" when the first item is active. When
_canCycleThroughPaginationistrue, though, the buttons are never disabled so this pattern does not apply.Consider reworking the Hot Graphic popup aria labels for Previous and Next to more closely align with Narrative. adaptlearning/adapt-contrib-narrative#311
For the Previous button, instead of relying on the presence of a
titleproperty for determining when we're at the beginning, we would rely on the_isAtStartproperty. Likewise, for the Next button, we would rely on_isAtEnd.We would also need to account for when the items can be looped through when
_canCycleThroughPaginationistrue. Narratives do not offer this option. So, it's possible that this rework is not necessary or should be adjusted to accommodate looping.