Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash: Respect completion-ignore-case readline setting #41

Open
2 of 4 tasks
adaszko opened this issue Feb 3, 2024 · 0 comments
Open
2 of 4 tasks

Bash: Respect completion-ignore-case readline setting #41

adaszko opened this issue Feb 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@adaszko
Copy link
Owner

adaszko commented Feb 3, 2024

In JIT mode, the current bash completion matching logic simply does completion.starts_with(...) which is wrong when completion-ignore-case is set.

Similarly in AOT mode:

Fix: Retrieve the settings value with something like bind -V | grep completion-ignore-case and behave conditionally based on its value.

  • TODO:
    • Write e2e tests for JIT mode
    • Wrte e2e tests for AOT mode
    • Fix JIT mode
    • Fix AOT mode
@adaszko adaszko added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Feb 3, 2024
adaszko added a commit that referenced this issue Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant