Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bootstrap 4 #108

Open
fif10 opened this issue Jan 6, 2018 · 6 comments
Open

Upgrade bootstrap 4 #108

fif10 opened this issue Jan 6, 2018 · 6 comments

Comments

@fif10
Copy link

fif10 commented Jan 6, 2018

Hello

I just wanted to know if there is any plan to upgrade to bootstrap 4.

Thanks a lot for the great work.

@rmpestano
Copy link
Contributor

Hi there,
AdminFaces is based on AdminLTE which is not compatible with BS 4 at moment, follow this issue for more details: ColorlibHQ/AdminLTE#710

So unfortunately we'll not be able to upgrade right now but as soon AdminLTE brings BS4 support we can start working on this.

Just out of curiosity, what features of BS4 you're missing the most right now?

@fif10
Copy link
Author

fif10 commented Jan 7, 2018

Hi

Thank you for your reply.

Not really missing features, but my concern was mainly to use bs3 features (or custo usage) incompatible with bs4 if you were about to release soon. (was also alot of curiosity :=))

Thanks a lot.

@rruffer
Copy link

rruffer commented Jan 9, 2019

I understand that the admin-theme is based on admin lite. But I could throw a theme apart with bootstrap 4. just incorporating the same css. without anything from admin lite.

@rmpestano
Copy link
Contributor

Hi @rruffer,

so the without bootstap classifier plus BS4, works for you?

To be honest I've never tried BS4, if replacing BS3 with 4 don't break existing applications then I have no problems in upgrading and would accept PRs.

Thanks for weighing in.

@rruffer
Copy link

rruffer commented Jan 9, 2019

It is an option. I'll test. But I believe you will not be 100%

@dguna
Copy link

dguna commented Jan 20, 2021

Hello,
Thanks for the good work. AdminLTE 3 is released and it supports BS4. Will Adminfaces will support BS4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants