Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome bug breaking top level item links on touchscreen PCs #31

Open
peterc opened this issue Dec 8, 2015 · 4 comments
Open

Chrome bug breaking top level item links on touchscreen PCs #31

peterc opened this issue Dec 8, 2015 · 4 comments

Comments

@peterc
Copy link

peterc commented Dec 8, 2015

Sorry if this is the wrong place, but I spent hours yesterday digging into an issue. I am mostly reporting so others encountering this can feel a little more sane.. :)

Random Windows users were complaining that top level menu items were not clickable anymore. That is, they would not follow to their usual links, all they would do is open and close their submenus (or do nothing if they didn't have submenus).

After significant amounts of debugging, we found that they were all users with Windows devices with touchscreens (both laptops and desktops). "isTouch" was coming up as true on those devices and, for some reason, Chrome 47 is now triggering "ontouchstart" events even for mouse clicks. We believe this latter part is a bug in Chrome, but either way, it affects the accessible mega menu's operation when in "touch" mode.

Our workaround has been to hard code isTouch as false and now everything works fine, even on iOS and Android as both Safari and Chrome seem to be smart enough to deal with initial clicks representing hover states.

@Philippe-dev
Copy link

I am experiencing the same bug but with all touch devices. The demo page does not work either for top level items where links cannot be followed.

@peterc : could you lease explain how to "hard code isTouch as false"? I tried in several places, but so far to no avail

@Nfinished
Copy link

@peterc Could you elaborate on how and where to set isTouch to false?

@peterc
Copy link
Author

peterc commented Apr 13, 2016

It's been a while now so I can't remember, but I seem to recall I merely searched the code for isTouch and when it was checked, I forced it to be false.

@llahnoraa
Copy link

+1

It doesn't work on iPad or any of the tablet devices. This needed to be resolved as soon as possible.

This is a great plugin, btw, but needed to be fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants