Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for text wrapping #7

Open
dirkschulze opened this issue Aug 15, 2014 · 12 comments
Open

No support for text wrapping #7

dirkschulze opened this issue Aug 15, 2014 · 12 comments

Comments

@dirkschulze
Copy link
Contributor

Photoshop support auto wrapping of text. SVG doesn't have that yet. We need to simulate it. Generator does not provide all needed information about this yet. JS doesn't help here, since we export SVG images which are not allowed to run scripts.

See adobe-photoshop/generator-core#250

@joebowden
Copy link

This is critical for Crema - otherwise, we don't have feature parity with the older generator svg engine.

@joebowden joebowden added the bug label Aug 22, 2014
@dirkschulze
Copy link
Contributor Author

Not sure what you mean, the old engine doesn't have text wrapping.

@joebowden
Copy link

The old engine supports hard returns for multiline text.

@dirkschulze
Copy link
Contributor Author

We do as well. We even have multiple tests for that.

@joebowden
Copy link

Hmm...I do see separate lines, but they're overlapping. Is that expected?

@dirkschulze
Copy link
Contributor Author

no, could you send me your test please?

@joebowden
Copy link

Thanks Dirk - emailed a test file.

@nimbupani
Copy link
Contributor

Need to fix this for parity with CC Extract's SVG output.

@dirkschulze
Copy link
Contributor Author

Request has been submitted to Generator a while back ago. It seems that we disagree on expectations of developers with the Generator team: adobe-photoshop/generator-core#250

@joebowden
Copy link

Hard returns are working now in Crema. We would have parity with Extract if we supported paragraph text with soft returns.

Here's a test file that Crema currently does not wrap the text for: http://adobe.ly/1lODgkY

@dirkschulze, extract/graphite handles the soft returns using t-span elements, which of course don't actually wrap in a browser - but, that is the kind of parity that Crema is looking for with extract right now. Is that a different issue than this one?

@dirkschulze
Copy link
Contributor Author

Hard returns should have worked from the beginning in svgOMG. The soft returns is what I was after. And yes, this can just be implemented with more tspans. Just like we do for hard returns.

@mvujovic mvujovic self-assigned this Dec 9, 2014
@mvujovic
Copy link
Contributor

mvujovic commented Dec 9, 2014

I'm actively working on this.

dirkschulze added a commit that referenced this issue Jun 16, 2015
Preserve as many data in OM as possible and change the gradient in svgWr...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants