Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generic caconfig retriever utility #111

Closed
chrischrischris opened this issue Jun 16, 2020 · 2 comments
Closed

Add a generic caconfig retriever utility #111

chrischrischris opened this issue Jun 16, 2020 · 2 comments
Assignees
@npeltier

Comments

@chrischrischris
Copy link
Contributor

As pointed out in this comment the resolveGradient method in BackgroundGradient.java has no need to be specific to gradients.

That file should be removed in favor of a ContextAwarePropertyRetriever utility that can be used to retrieve any caconfig value.
@chrischrischris chrischrischris mentioned this issue Jun 16, 2020
Merged
@npeltier
Copy link
Contributor

working on GH-24, i think i found a nice way, let's see if that work, and then close this one

@npeltier
Copy link
Contributor

so @auniverseaway saw GH-24's StyleGuide, and i guess we're ok removing BackgroundGradientModel. will do that tomorrow

@npeltier npeltier self-assigned this Sep 15, 2020
npeltier added a commit that referenced this issue Sep 16, 2020
@npeltier
@releng different fixes
ceec7ac 
- remove BackgroundGradient as we need now to use StyleGuide.gradients (cf. GH-24, GH-111),
- remove FlexModel's prefix of id introduced in GH-24 since GH-143 fixes the core issue,
- fixes a few sonar bugs & smells
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npeltier npeltier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@npeltier @chrischrischris