Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VH should not be in CSS during authoring #163

Open
auniverseaway opened this issue Sep 26, 2020 · 0 comments
Open

VH should not be in CSS during authoring #163

auniverseaway opened this issue Sep 26, 2020 · 0 comments

Comments

@auniverseaway
Copy link
Member

auniverseaway commented Sep 26, 2020

Due to AuthorVH outputting data attributes during authoring, we should not have the CSS for VH also being output. The existing pixel based values should still be output.

Expected Behaviour

<!-- editor.html -->
<style>#flex-5c12994e {}</style>
<!-- editor.html -->
<style>#flex-5c12994e {height: 100px}</style>

Actual Behaviour

<!-- editor.html -->
<style>#flex-5c12994e {height:60vh}</style>
<!-- editor.html -->
<style>#flex-5c12994e {height: 100px}</style>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant