Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketo Form Profile Service #187

Open
yesil opened this issue May 10, 2021 · 2 comments
Open

Marketo Form Profile Service #187

yesil opened this issue May 10, 2021 · 2 comments

Comments

@yesil
Copy link

yesil commented May 10, 2021

This is about enhancing Marketo Form component with:

  • A Profile URL that;

    • will be defined in the cloud config
    • will be called via XHR at the frontend during form rendering
    • will return the list of unknown fields in a given form, so that all the known form fields can be removed from the form
    • e.g: { "fields": ["Company"] }
  • An option to enable Profile Service in the form component dialog

  • An option to auto-submit the form if all the form fields are known(pre-filled)

  • An alternate verbiage for the submit button in the event all the form fields are known

  • A Destination URL to redirect to once the form submission is successful

The form component dialog options should appear only if the Profile URL is defined in the cloud configuration

@yesil
Copy link
Author

yesil commented May 10, 2021

I would like to use a render condition to display the Profile Service specific options in the form dialog only if the Profile URL is defined in the Marketo cloud config.

The question is if I extend com.adobe.dx.admin.rendercondition.AbstractRenderCondition do I need to put my marketo specific render condition in the admin module in which case I cannot use com.adobe.dx.content.marketo.models.internal.MarketoConfBasicInfo? to map the marketo config.

Alternatively I can add a CloudConfigPropertyRenderCondition in the admin module which will check if a given property is defined in a given cloud config?

Which one is preferable?

@npeltier
Copy link
Contributor

@yesil definitely the later, as it will not break the modularisation.

yesil added a commit to yesil/adobe-dx that referenced this issue May 12, 2021
yesil added a commit to yesil/adobe-dx that referenced this issue May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants