Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug label not intuitive, should be log prefix? #6

Open
moritzraho opened this issue Sep 26, 2019 · 1 comment
Open

Debug label not intuitive, should be log prefix? #6

moritzraho opened this issue Sep 26, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@moritzraho
Copy link
Member

Expected Behaviour

test.js:

const logger = require('@adobe/aio-lib-core-logging')('myapp', { provider: './DebugLogger' })
logger.debug('yo!')

DEBUG=myapp node test.js => should print yo!

Actual Behaviour

Need to add a * to the DEBUG env var
DEBUG=myapp* node test.js => prints yo!

This is because the debug label is extended with action name and log level

suggestion: preserve the user given debug key but add a string prefix to each log message

@shazron
Copy link
Member

shazron commented Sep 27, 2019

Agree, this should be consistent for all loggers

@meryllblanchet meryllblanchet added the enhancement New feature or request label Nov 25, 2019
@meryllblanchet meryllblanchet added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 8, 2020
@meryllblanchet meryllblanchet assigned rajarju and unassigned Himavanth Jun 16, 2020
@shazron shazron mentioned this issue May 27, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants