Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-55] Docker multi-stage build #56

Closed
wants to merge 5 commits into from
Closed

[GH-55] Docker multi-stage build #56

wants to merge 5 commits into from

Conversation

OneCricketeer
Copy link
Contributor

Summary

After Gradle clean

$ docker build --no-cache -t streaming-connect .
...
=> => transferring context: 25.73kB

Related Issue

Closes #55

Changes

Update Dockerfile and .dockerignore to not use copied-in artifacts and rather build within the container

Benefits

  1. Consistent build versions. I have JDK 17 as default, but the runtime image wants JRE 11
  2. Faster build contexts, with the tradeoff of pulling more images (which would be cached later)

How Has This Been Tested?

Local builds

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@OneCricketeer OneCricketeer closed this by deleting the head repository Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Docker Daemon Context
1 participant