Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"colorSpace" key does not work when written in camel-case #190

Closed
skylerknight opened this issue Dec 10, 2022 · 2 comments · May be fixed by #191
Closed

"colorSpace" key does not work when written in camel-case #190

skylerknight opened this issue Dec 10, 2022 · 2 comments · May be fixed by #191
Labels
bug Something isn't working

Comments

@skylerknight
Copy link

Description

Color space is not set when using camel-case colorSpace, but works when using all lowercase colorspace

In the documentation code snippets, it shows as camel-case.

Expected behavior

I feel like it should be using camel-case, similar to colorKeys OR the code snippets should be changed to match.
Not sure if this was already fixed in later versions. But leaving a note just in case.

Screenshots

Screen Shot 2022-12-10 at 12 53 11 PM

Leonardo package and version

@leonardo-contrast-colors version: 1.0.0-alpha.13

Environment

  • Browser(s) and OS(s): Version 108.0.5359.98 (Official Build) (arm64)
@skylerknight skylerknight added the bug Something isn't working label Dec 10, 2022
@skylerknight skylerknight changed the title "colorSpace" key does not work when written in camel-case v1.0.0-alpha.13 "colorSpace" key does not work when written in camel-case Dec 10, 2022
@GarthDB
Copy link
Member

GarthDB commented Dec 11, 2022

Agreed, we should probably standardize on either "colorspace" or "color space" (and colorSpace).

I'm leaning toward 2 words, so camel case, as you've suggested @skylerknight.

@NateBaldwinDesign
Copy link
Collaborator

This is a good call out. Camel case would be consistent with other parameters.

GarthDB added a commit that referenced this issue Dec 11, 2022
@GarthDB
fix!: change colorspace to colorSpace to be consistent. fixes #190
e2f6146 
BREAKING CHANGE: It could be considered a typo, but it will be a
breaking change for anyone using leonard previously.
@GarthDB GarthDB mentioned this issue Dec 11, 2022
Open
2 tasks
GarthDB added a commit that referenced this issue Mar 14, 2024
@GarthDB
fix!: change colorspace to colorSpace to be consistent. fixes #190
faae5f9 
BREAKING CHANGE: It could be considered a typo, but it will be a
breaking change for anyone using leonard previously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change colorspace to colorSpace to be consistent adobe/leonardo
3 participants
@GarthDB @NateBaldwinDesign @skylerknight