fix(field-label): address edge case where required icon would not render on the same line

cdransf · cdransf · commit e7152a1965a1 · 2025-10-31T16:13:54.000-07:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -22,7 +22,7 @@ parameters:
     # 3. Commit this change to the PR branch where the changes exist.
     current_golden_images_hash:
         type: string
-        default: 94764405d1674838a93d6c6a39e793df39fc301e
+        default: acdec8d8f41b5c15af16b93f14c5a87e03d66497
     wireit_cache_name:
         type: string
         default: wireit
diff --git a/packages/field-label/src/field-label.css b/packages/field-label/src/field-label.css
@@ -14,5 +14,7 @@
 @import url("./field-label-overrides.css");
 
 label {
-    display: inline-block;
+    display: inline-flex;
+    align-items: baseline;
+    white-space: nowrap;
 }
diff --git a/packages/field-label/src/spectrum-field-label.css b/packages/field-label/src/spectrum-field-label.css
@@ -78,6 +78,7 @@
     margin-inline: var(--mod-field-label-text-to-asterisk, var(--spectrum-field-label-text-to-asterisk)) 0;
     vertical-align: initial;
     vertical-align: var(--mod-field-label-asterisk-vertical-align, baseline);
+    flex-shrink: 0;
 }
 
 :host([side-aligned="start"]),

Original file line number	Diff line number	Diff line change
`@@ -14,5 +14,7 @@`
`14`	`14`	`@import url("./field-label-overrides.css");`
`15`	`15`
`16`	`16`	`label {`
`17`		`- display: inline-block;`
	`17`	`+ display: inline-flex;`
	`18`	`+ align-items: baseline;`
	`19`	`+ white-space: nowrap;`
`18`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,7 @@`
`78`	`78`	`margin-inline: var(--mod-field-label-text-to-asterisk, var(--spectrum-field-label-text-to-asterisk)) 0;`
`79`	`79`	`vertical-align: initial;`
`80`	`80`	`vertical-align: var(--mod-field-label-asterisk-vertical-align, baseline);`
	`81`	`+ flex-shrink: 0;`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`:host([side-aligned="start"]),`