Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong baseUrl that breaks path alias in vs code #12

Open
guoyunhe opened this issue Nov 13, 2022 · 0 comments · May be fixed by #13
Open

Wrong baseUrl that breaks path alias in vs code #12

guoyunhe opened this issue Nov 13, 2022 · 0 comments · May be fixed by #13

Comments

@guoyunhe
Copy link

https://github.com/adonisjs-community/adonis-preset-ts/blob/develop/tsconfig.json#L22

It is strange that VS Code's built-in TypeScript parser will alert about wrong paths:

图片

After deleting baseUrl option in node_modules/adonis-preset-ts/tsconfig.json, VS Code won't show any path error anymore.

I think a ts preset package should not contain baseUrl or rootDir option. Since the project has already defined them.
guoyunhe added a commit to guoyunhe/adonis-preset-ts that referenced this issue Jan 31, 2023
@guoyunhe
Remove relative baseUrl, rootDir and outDir
51d5898 
For the following reason:
1. These relative path breaks in pnpm
2. Project template has already defined them in tsconfig.json, so no need to include them in preset

Fix adonisjs-community#12
@guoyunhe guoyunhe linked a pull request Jan 31, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove relative baseUrl, rootDir and outDir guoyunhe/adonis-preset-ts
1 participant
@guoyunhe