Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Snippets): Add Edge and Adonis Snippets #9

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

toksdotdev
Copy link
Contributor

Resolves #4.

@toksdotdev
Copy link
Contributor Author

toksdotdev commented Dec 19, 2019

I was considering prefixing all the snippet triggers with ad:.

Although, prefixing might not eventually be necessary considering that we could restrict the extension to run only in an adonis project (#10).

Pros:

  • Easy to understand
  • Easy to distinguish adonis snippets from vscode suggestions.

Cons:

  • Extra 3 characters (hence making commands longer to type).

@guledali
Copy link

guledali commented May 13, 2020

@tnkemdilim @thetutlage When is this extension going to get released to marketplace

Any fixed date?

@thetutlage
Copy link
Member

Some of the work is still pending and the final polishing. Not 100% sure, when I'll begin working on it. But happy, you or someone else wants to pick up the development

@toksdotdev
Copy link
Contributor Author

toksdotdev commented May 13, 2020

So far, the major pending tasks (asides from final polishing) includes:

  • Merging the snippets into master (status: completed);

Decision about prefixing the snippets commands is yet to be concluded on as mentioned earlier in this thread.

There are still deliberations on whether to ship the vscode html language server with the extension or write a custom one, considering that it'll increase the download size of the extension (a comparison of compiled extension size from both will be performed to see if it's worth a tradeoff).

  • Documentation of internal workings.

I'll work on completing the above at the latter part of this month. Although, would really appreciate if you could join in the development.

@thetutlage
Copy link
Member

@tnkemdilim

I was actually thinking to release the extensions in multiple phases.

  • In the first phase, we can ship with the autocompletion of controllers and edge templates, along with Edge syntax support
  • The 2nd phase will be swap adonis cli commands with node ace. Initially, we wrote the extension by keeping adonis cli in mind, but now the landscape has changed.
  • Add .adonisrc.json schema file for JSON autocomplete.

@thetutlage
Copy link
Member

So it will be matter of creating a few branches, each dedicated to a single release.

@toksdotdev
Copy link
Contributor Author

toksdotdev commented May 13, 2020

@thetutlage

Releasing incrementally is definitely a great idea.

Would you suggest releasing the edge snippets initially?

What i'll need to do:

  • Create the expected releases into separate branches.
  • Check the ace CLI tasks in v5 for breaking changes.
  • Highlight what needs to be done for v5 compatibility on the project board.

@guledali
Copy link

@tnkemdilim @thetutlage It has been over a month now, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snippets
3 participants