Cannot register handlers for : key

[edwardhelsby-intercom]

Handlers registered against : using the on-key helper do not work.

ember-keyboard/addon/src/utils/keyboard-listener.js

Line 24 in 933e1df

let [eventType, keyCombo] = s.split(':');

let [eventType, keyCombo] = 'keyDown::'.split(':');
keycombo = ''

[SergeAstapov]

@edwardhelsby-intercom could you please provide some more info, e.g. how did you try to use the on-key helper and which arguments were provided?

[edwardhelsby-intercom]

Sure! within a template like so:

{{on-key ':' this.doThing}}

With that in the template, pressing : does not trigger this.doThing

[SergeAstapov]

@edwardhelsby-intercom could you please try [email protected] and confirm if it fixes an issue you reported?

I accidentally pushed the fix to the master branch instead of doing PR via 56621f2 🙈

[edwardhelsby-intercom]

@edwardhelsby-intercom could you please try [email protected] and confirm if it fixes an issue you reported?

I accidentally pushed the fix to the master branch instead of doing PR via 56621f2 🙈

Thanks for making that fix 🚀 I'm a couple of major versions behind so it may be a while before able to test that out