Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider impact of glint on API design #717

Open
lukemelia opened this issue Jan 19, 2023 · 4 comments
Open

Consider impact of glint on API design #717

lukemelia opened this issue Jan 19, 2023 · 4 comments

Comments

@lukemelia
Copy link
Collaborator

Before glint/gts, having a modifier and helper with the same name didn't cause any issues, but it is a point of annoyance when working with glint. It's not a show stopper, because .gts file authors can easily alias the helper or modifier when importing it, but it would be good to consider a plan to evolve the addon to be more friendly in its default naming.

@swastik
Copy link

swastik commented Mar 28, 2023

We're running into this introducing Glint to our codebase—we use ember-keyboard quite a lot. If there are plans to rename one of them, or if we can figure out another solution, that'd be great! I'm also happy to help in any way. 😄

@lukemelia
Copy link
Collaborator Author

I think we need to consider renaming and doing a major release. Any ideas on names?

@swastik
Copy link

swastik commented Mar 28, 2023

I'm wondering if there's a clear difference between the two: on-key modifier adds listeners to the element that applies it, whereas on-key the helper adds it to the document.

Could we use something like on-document-key for the helper and on-key for the modifier? Or something along those lines?

@lukemelia
Copy link
Collaborator Author

@swastik I'm OK with they proposed name change for the helper. We'll need a plan for migrating, deprecating, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants