Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legal: check copyrights, attribution and licencing #2

Closed
rzr opened this issue Jan 8, 2020 · 17 comments
Closed

legal: check copyrights, attribution and licencing #2

rzr opened this issue Jan 8, 2020 · 17 comments

Comments

@rzr
Copy link
Collaborator

rzr commented Jan 8, 2020

Relate-to: adoptware/pinball#4

Is @paolo-caroni the only author ?

Please edit debian/copyright to make sure nothing is left

cc: @zezinho42

@paolo-caroni
Copy link
Contributor

Hi, I'm the only author.
however part of files are "stealed" from tux table by Henrik Enqvist (see README).
In 2010 I was convinced that the HURD and GNU logos were distributable under GPLv2+, a more thorough check now made it clear that I was wrong.

@rzr
Copy link
Collaborator Author

rzr commented Jan 8, 2020

Hi @paolo-caroni long time no see

May I request you to check my comments

#3

Then we can try to submit this table to debian (and derived)

@paolo-caroni
Copy link
Contributor

paolo-caroni commented Jan 8, 2020

Hi @rzr it's a very long time,
if you think that it's better specify exactly what file are released under what licence on debian/copyright I can divide it...
I'm simply lazy, so seems simple to me send to the README.txt file, but if for distribute under debian you need more specification... Ask me and I will rewrite debian/copyright.
cheers

@rzr
Copy link
Collaborator Author

rzr commented Jan 8, 2020

well this is what debian's parser expects:

https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

you can check using lintian, if you dont use debian
you can run it with

docker build .

May @zezinho42 help for

adoptware/pinball-table-gnu#2

@rzr
Copy link
Collaborator Author

rzr commented Jan 8, 2020

Please rebase on master I have just setup CI:

Check 1st log at:
https://travis-ci.com/rzr/pinball-table-hurd/builds/143638046

@paolo-caroni
Copy link
Contributor

I think you are overestimating my computer skills, I'm in a nerd but a bad programmer and I'm not sure that I can be defined as such.
I have basic skills in C, I'm doing well with CAD drawing and thanks to this I have been able to draw the tables quite well.
Over the years I am improving, but honestly I did not understand what you asked me.
Do you want to delete my fork and redo a new one starting from your current "main"?

@rzr
Copy link
Collaborator Author

rzr commented Jan 9, 2020

No problem let me explain what is rebasing check those hints:

https://purl.org/rzr/flows#

try in your repo:

git remote add upstream https://github.com/rzr/pinball-table-hurd
git fetch --all
git rebase -i remotes/upstream/master
git push -f

@rzr
Copy link
Collaborator Author

rzr commented Jan 10, 2020

You can also names AUTHORS file and open a separate PR
I will merge it

@rzr rzr closed this as completed Jan 10, 2020
@rzr rzr reopened this Jan 10, 2020
@rzr
Copy link
Collaborator Author

rzr commented Jan 25, 2020

rzr added a commit that referenced this issue Feb 23, 2020
Change-Id: I2d3da32fc9feede36ef6af11f60663ef8cfd2936
Relate-to: #2
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this issue Feb 23, 2020
Change-Id: I2d3da32fc9feede36ef6af11f60663ef8cfd2936
Relate-to: #2
Signed-off-by: Philippe Coval <[email protected]>
@rzr
Copy link
Collaborator Author

rzr commented Feb 23, 2020

Hi @paolo-caroni ,

As suggested in:

#5

Please add "AUTHORS" file , and close this issue I will release a version,
is it OK for you ?

Regards

@paolo-caroni
Copy link
Contributor

The copyright is correct and complete, still missing Upstream Contact (https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#upstream-contact-field).
It seems to me that the Upstream-Contact are URIs to reach the project, so I think the better URI can be my mail or the URL here on github.
What do you think about it?

Cheers

@rzr
Copy link
Collaborator Author

rzr commented Feb 24, 2020

well I think this repo is upstream so I can add it.

rzr added a commit that referenced this issue Feb 24, 2020
Change-Id: I2d3da32fc9feede36ef6af11f60663ef8cfd2936
Relate-to: #2
Signed-off-by: Philippe Coval <[email protected]>
@rzr
Copy link
Collaborator Author

rzr commented Feb 24, 2020

I think I am near to release, please confirm it's fine

Eventually add debian/upstream and add AUTHORS file and then I'll tag 0.0.YYYYMMDD and update debian packaging (from debian/master branch)

Relate-to: #5

rzr referenced this issue in paolo-caroni/pinball Feb 24, 2020
@paolo-caroni
Copy link
Contributor

For me it's fine, maybe Upstream-Contact: "paolo-caroni" can be "Paolo Caroni" in /debian/copyright.txt but honestly it's the same for me.
thank you :)

rzr added a commit that referenced this issue Feb 24, 2020
Change-Id: I2d3da32fc9feede36ef6af11f60663ef8cfd2936
Relate-to: #2
Signed-off-by: Philippe Coval <[email protected]>
@rzr
Copy link
Collaborator Author

rzr commented Feb 24, 2020

OK, I updated that file
so please close this ticket to acknowledge that legal requirements are fine.

If there is no change coming, I will release tomorrow

@paolo-caroni
Copy link
Contributor

Maybe I'm blind, maybe I don't know well github... but seems to me that I can't close this issue since I haven't opened it.
I'm wrong?
For me is totally ok release tomorrow or when you have time.
Cheers,
Paolo

@rzr
Copy link
Collaborator Author

rzr commented Feb 24, 2020

Ok sorry I can close it for you :)

I might update readme

@rzr rzr closed this as completed Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants