Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github-enterprise #159

Open
sebastienbrunkyndryl opened this issue Aug 24, 2023 · 4 comments
Open

Github-enterprise #159

sebastienbrunkyndryl opened this issue Aug 24, 2023 · 4 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@sebastienbrunkyndryl
Copy link

Is-it possible to deploy your solution with an dedicated github-enterprise solution ?

during the login phase, no possibility to choose the target github server.

@xJREB
Copy link
Collaborator

xJREB commented Sep 15, 2023

I'm not really sure if the APIs differ between the public and the enterprise versions. If they don't for the relatively standard functionality that the ADR Manager uses, then it could be as simple as changing the base endpoint and the rest should work. If they do, it might be more work. We are planning to rework the authentication and the API access anyway to get rid of Pizzly in the middle. That might be a good opportunity to prepare for such changes.

If you want to help, you could try to investigate how the GitHub Enterprise API differs from the public GitHub API, and report the details back here. That would make it much easier to plan and implement such a feature.

@xJREB xJREB added enhancement New feature or request duplicate This issue or pull request already exists labels Sep 15, 2023
@xJREB
Copy link
Collaborator

xJREB commented Sep 15, 2023

Duplicate of #41

@xJREB xJREB marked this as a duplicate of #41 Sep 15, 2023
@koppor
Copy link
Member

koppor commented Sep 15, 2023

Roadmap:

Since MADR 4.0.0 is almost complete, @sebastienbrunkyndryl do you know about resources helping to upgrade ADR-Manager?

@xJREB
Copy link
Collaborator

xJREB commented Sep 15, 2023

@koppor, we should also not forget about #156, as it will lead to lots of changes in the code. Right now, Pizzly is very tightly integrated in the code and needs to be replaced in many functions. It should definitely be removed before implementing support for other Git platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants