-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Include PlantUML diagrams at arbitrary positions in doc #28
Feature/Include PlantUML diagrams at arbitrary positions in doc #28
Conversation
# Conflicts: # .gitignore
# Conflicts: # build.js
Thanks for the pull request, I'll come back to this after I push all the other PRs |
@adrianvlupu Is it possible to review this at this time? Thank you! |
I have done an update to this PR but not able to commit it.
If someone could give me a hint on getting this into this PR or if I need to push it as a new PR |
@MickeJohannesson Your changes look quite useful. But they seem like multiple PRs. Can you break it up and submit PRs separately? |
The problem is that all changes (more or less) are made in the build.js file. And I have done them in the version from this PR. |
This seems like very handy feature and its pending for some time. If we could figure out conflicts and a path forward that would be awesome. Please let me know if there is anything i can do to help |
Thanks for the implementation. I couldn't merge it properly but the functionality is there from another PR (that included your changes) and my refactoring. You can include diagrams using |
Addition of the possibility of including diagrams at an arbitrary position via the use of markdown syntax ![](_diagram.puml).
Fixes #21