Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for python 3.9 #103

Merged

Conversation

ChinoUkaegbu
Copy link
Contributor

@ChinoUkaegbu ChinoUkaegbu commented Sep 15, 2024

Fixes #102

@adrianyorke
Copy link
Owner

Thanks for the PR @ChinoUkaegbu 👍

@adrianyorke
Copy link
Owner

Python 3.12 CI tests are failing, both ubuntu and windows. You could try changing webdrivermanager to webdriver_manager in requirements 3.12, as per this discussion:
MarketSquare/webdrivermanager#103

@ChinoUkaegbu
Copy link
Contributor Author

Done!

@adrianyorke
Copy link
Owner

Thanks @ChinoUkaegbu.

Unfortunately, webdrivermanager depends on versioneer which does not currently support Python 3.12.

In order get your PR merged, I suggest cookbook should only supports Python 3.10 and 3.11 at this time. We can revist adding support for Python 3.12 at a later date when versioneer has caught up.

More info:
https://github.com/python-versioneer/python-versioneer

@ChinoUkaegbu ChinoUkaegbu changed the title chore: remove support for python 3.9 and add python 3.12 chore: remove support for python 3.9 Sep 16, 2024
@ChinoUkaegbu
Copy link
Contributor Author

I see, I've reflected the changes so support for 3.9 is dropped.

@adrianyorke
Copy link
Owner

@all-contributors please add @ChinoUkaegbu for Code

Copy link
Contributor

@adrianyorke

I've put up a pull request to add @ChinoUkaegbu! 🎉

@adrianyorke adrianyorke merged commit 046e025 into adrianyorke:master Sep 16, 2024
2 of 5 checks passed
@adrianyorke
Copy link
Owner

Excellent work @ChinoUkaegbu, thank you 🙏

@ChinoUkaegbu
Copy link
Contributor Author

You're welcome, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time to bump Python versions - drop support for 3.9
2 participants