Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib - FEAT: France Connect #53

Open
wants to merge 8 commits into
base: main_adullact
Choose a base branch
from

Conversation

akarzim
Copy link

@akarzim akarzim commented Jun 14, 2021

see:

Considérations techniques

Tester le workflow complet d'une authentification FranceConnect nécessite de faire des requêtes HTTP externes telles que https://fcp.integ01.dev-franceconnect.fr/api/v1/token ou https://fournisseur-d-identite.dev-franceconnect.fr/user/authorize, ce que Capybara ne nous permet pas malgré l'utilisation de cassettes via la gem vcr.

Note: the default driver (:rack_test) does not support running against a remote server. With drivers that support it, you can also visit any URL directly

source: https://github.com/teamcapybara/capybara#calling-remote-servers

C'est pourquoi nous avons fait le choix d'ajouter la gem capybara-mechanize aux dépendances du projet.

Malheureusement, une incompatibilité avec Ruby 3.0 a été détectée et met nos tests en échec. Ce comportement a fait l'objet d'un ticket (phillbaker/capybara-mechanize#68) sur le dépôt du projet, toujours ouvert à ce jour.

C'est pourquoi, dans l'attente d'un support officiel de Ruby 3.0 par les auteurs de cette gem, nous avons fait le choix de nous rabattre sur un fork qui corrige cette incompatibilité.

Captures d'écran

Screenshot 2021-12-24 at 11-06-46 localhost 8080
Screenshot 2021-12-24 at 11-07-10 localhost 8080
Screenshot 2021-12-24 at 11-07-45 Ma démarche · localhost 8080
Screenshot 2021-12-24 at 11-08-00 Connexion - choix du compte
Screenshot 2021-12-24 at 11-08-06 https fournisseur-d-identite dev-franceconnect fr
Screenshot 2021-12-24 at 11-08-15 Connexion - Continuer sur Service FSPublic - FranceConnect
Screenshot 2021-12-24 at 11-09-02 Ma démarche · localhost 8080

@dzc34 dzc34 changed the title 6159 feature france connect Contrib - FEAT: france connect Jun 14, 2021
@dzc34 dzc34 changed the title Contrib - FEAT: france connect Contrib - FEAT: France Connect Jun 14, 2021
@dzc34 dzc34 mentioned this pull request Jun 14, 2021
@akarzim akarzim force-pushed the 6159_feature_france-connect branch 10 times, most recently from f81d09f to ab9a02a Compare December 24, 2021 14:48
@akarzim akarzim force-pushed the 6159_feature_france-connect branch 2 times, most recently from 62ac122 to ebce6e5 Compare January 31, 2022 14:29
@akarzim akarzim force-pushed the 6159_feature_france-connect branch from 9d5d6d9 to a784d8b Compare March 18, 2022 09:43
@dzc34 dzc34 changed the base branch from main to main_adullact March 18, 2022 11:24
@akarzim akarzim force-pushed the 6159_feature_france-connect branch from a784d8b to 8514358 Compare April 7, 2022 05:09
@akarzim akarzim force-pushed the 6159_feature_france-connect branch from 8514358 to 2a9feb1 Compare April 21, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants