forked from demarches-simplifiees/demarches-simplifiees.fr
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrib - FEAT: France Connect #53
Open
akarzim
wants to merge
8
commits into
main_adullact
Choose a base branch
from
6159_feature_france-connect
base: main_adullact
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
akarzim
force-pushed
the
6159_feature_france-connect
branch
10 times, most recently
from
December 24, 2021 14:48
f81d09f
to
ab9a02a
Compare
akarzim
force-pushed
the
6159_feature_france-connect
branch
2 times, most recently
from
January 31, 2022 14:29
62ac122
to
ebce6e5
Compare
akarzim
force-pushed
the
6159_feature_france-connect
branch
from
February 18, 2022 13:50
ebce6e5
to
547944c
Compare
akarzim
force-pushed
the
6159_feature_france-connect
branch
from
March 18, 2022 09:43
9d5d6d9
to
a784d8b
Compare
akarzim
force-pushed
the
6159_feature_france-connect
branch
from
April 7, 2022 05:09
a784d8b
to
8514358
Compare
akarzim
force-pushed
the
6159_feature_france-connect
branch
from
April 21, 2022 14:15
8514358
to
2a9feb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see:
Considérations techniques
Tester le workflow complet d'une authentification FranceConnect nécessite de faire des requêtes HTTP externes telles que
https://fcp.integ01.dev-franceconnect.fr/api/v1/token
ouhttps://fournisseur-d-identite.dev-franceconnect.fr/user/authorize
, ce que Capybara ne nous permet pas malgré l'utilisation de cassettes via la gem vcr.source: https://github.com/teamcapybara/capybara#calling-remote-servers
C'est pourquoi nous avons fait le choix d'ajouter la gem capybara-mechanize aux dépendances du projet.
Malheureusement, une incompatibilité avec Ruby 3.0 a été détectée et met nos tests en échec. Ce comportement a fait l'objet d'un ticket (phillbaker/capybara-mechanize#68) sur le dépôt du projet, toujours ouvert à ce jour.
C'est pourquoi, dans l'attente d'un support officiel de Ruby 3.0 par les auteurs de cette gem, nous avons fait le choix de nous rabattre sur un fork qui corrige cette incompatibilité.
Captures d'écran