-
Notifications
You must be signed in to change notification settings - Fork 43
Types issue #38
Comments
Can you share code you use (no secrets, I'll use mine) and Node.js/npm
versions you use?
El dom., 5 jul. 2020 2:42, Shayne Hartford <[email protected]>
escribió:
… [image: image]
<https://user-images.githubusercontent.com/9505196/86523192-e2c08280-be36-11ea-98aa-d63043a9f9e9.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRLWQ4RMXFV3AI2PQCW5DRZ7EANANCNFSM4OQUAGFQ>
.
|
This is the project i'm using it in, though I have a |
Not sure what the problem is. Do you import the npm module? It should have
all the necessary files.
El dom., 5 jul. 2020 11:42, Shayne Hartford <[email protected]>
escribió:
… This is the project i'm using it in, though I have a
typings/tplink-cloud-api/index.d.ts file to let me compile, so that would
need removed https://github.com/shaybox/api, just delete all the route
files except for energy.ts and the import/use lines in index.ts, optionally
remove the now unused deps
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRLWRSQGTKYN4R67B7QGDR2BDJTANCNFSM4OQUAGFQ>
.
|
The problem is the package is written in typescript and transpiled to javascript without any type definitions, usually in this case you would either have typescript emit a definition file and provide that with the library on npm, or only transpile it to javascript for npm and set it up so typescript users can install it via github to get the typescript source, I wouldn't know how to set either of those up, here's the first article I found on the first method (generating type definitions) |
Could you try this release? It's not available yet on npm.
https://github.com/adumont/tplink-cloud-api/releases/tag/0.6.2-next.2
Just curious to see if it fixes the issue.
El lun., 6 jul. 2020 1:54, Shayne Hartford <[email protected]>
escribió:
… The problem is the package is written in typescript and transpiled to
javascript without any type definitions, usually in this case you would
either have typescript emit a definition file and provide that with the
library on npm, or only transpile it to javascript for npm and set it up so
typescript users can install it via github to get the typescript source, I
wouldn't know how to set either of those up, here's the first article I
found on the first method
<https://medium.com/cameron-nokes/the-30-second-guide-to-publishing-a-typescript-package-to-npm-89d93ff7bccd>
(generating type definitions)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRLWTSE6RDDUYHR27MII3R2EHCFANCNFSM4OQUAGFQ>
.
|
I just noticed this issue is still open, it was fixed |
EDIT:
Also unrelated but login being a promise is very inconvenient
The text was updated successfully, but these errors were encountered: