Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document specific engine log messages #243

Open
ivan-mogilko opened this issue Jan 30, 2024 · 4 comments
Open

Document specific engine log messages #243

ivan-mogilko opened this issue Jan 30, 2024 · 4 comments

Comments

@ivan-mogilko
Copy link
Contributor

There are script log messages in a following format:
(room:%d) [%s %d]
where ags will print error location in square brackets, using a single letter and a number.
https://github.com/adventuregamestudio/ags/blob/12b7f62fce17bb5fdbf4aa5464268b3dcbcebd67/Engine/debug/debug.cpp#L369

May be worth documenting their meaning somewhere. But also have to note that these may be engine-specific and change in future (just in case).

@ivan-mogilko ivan-mogilko changed the title Document log messages Document specific engine log messages Jan 30, 2024
@ericoporto
Copy link
Member

ericoporto commented Jan 31, 2024

There was the idea of GameFeatures that we didn't fleshed out, perhaps there with a link to/from the Log Panel page.

Other possibility is consider logging something in Engine, and then add a topic on Engine logging and place it there.

@ivan-mogilko
Copy link
Contributor Author

Yes, I think "engine logging" topic in Engine section would look better, because this is not really a game feature, it's just engine reporting about something.

@ericoporto
Copy link
Member

ericoporto commented Mar 2, 2024

Hey, I don't understand what the ? means in this case. It's not the game script (module ?), Room Script, or the Dialog Script. Which script is it than that would cause the ? character?

Edit: I think G means global script and ? means is any other script module.

@ivan-mogilko
Copy link
Contributor Author

ivan-mogilko commented Mar 3, 2024

Edit: I think G means global script and ? means is any other script module.

Right, and that's kind of weird. I think it's possible that this code was written at the time when custom modules did not exist were not supported, so the ? means "undefined behavior". Perhaps we should change it to something, like M or a module's index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants