Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated piggieback dependency? #60

Open
OlafMerkert opened this issue May 11, 2018 · 3 comments
Open

outdated piggieback dependency? #60

OlafMerkert opened this issue May 11, 2018 · 3 comments

Comments

@OlafMerkert
Copy link

It seems to me that com.cemerick/piggieback has been superseded by cider/piggieback. At least cider itself seems to be of that opinion. Should the dependency be updated?

@arichiardi
Copy link
Contributor

See #61

@arichiardi
Copy link
Contributor

I would say things are still evolving but I see that these deps will need to be updated for it to work:

https://github.com/adzerk-oss/boot-cljs-repl/blob/master/src/adzerk/boot_cljs_repl.clj#L18-L21

Another nice thing to do would probably be to read the current deps coming from build.boot and take those in case. The deps in the snipped above should be the default but not the only ones we consider.

@bbatsov
Copy link

bbatsov commented Jul 23, 2018

It seems to me that com.cemerick/piggieback has been superseded by cider/piggieback. At least cider itself seems to be of that opinion. Should the dependency be updated?

Btw, despite of the namespace that's not something to do with CIDER. At the time when the project was handed over to me the nREPL org didn't still exist and this seem like a reasonable coordinate for the artefact. I would have chosen nrepl/piggieback if I were doing this today, but it is what it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants