Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate using figwheel.client code #40

Open
martinklepsch opened this issue Oct 7, 2015 · 4 comments
Open

Evaluate using figwheel.client code #40

martinklepsch opened this issue Oct 7, 2015 · 4 comments

Comments

@martinklepsch
Copy link
Contributor

Pros:

  • community effort bundled in one project
  • dependency ordering + filtering of reloadable files would not need to be re-implemented

Cons:

  • potentially more complex to maintain (effort shared by more people though)
  • special cases for boot tooling might not be possible (e.g. displaying SASS compilation errors)
  • speed with which we could implement features/fixes might be reduced

Please discuss 😄

@Deraen
Copy link
Contributor

Deraen commented Oct 7, 2015

Would probably be possible for Figwheel to display any messages. Anyway as we continue to have our server, we can send errors from any boot task.

@Deraen
Copy link
Contributor

Deraen commented Oct 7, 2015

Figwheel client doesn't currently support reloading the HTML file, should be easy to implement though.

@martinklepsch
Copy link
Contributor Author

Alternatively maybe it would be an option to create something new that copies the dependency ordering etc but is flexible enough to be used as figwheel.client 2.0 as well as for boot-reload. edit: like some cljs-only library that gets websocket messages and reloads/displays stuff :)

@bhauman
Copy link

bhauman commented Oct 7, 2015

There is a plugin system of sorts in figwheel. You can pick up any messages you send from the server and act on them. This shouldn't be difficult.

Also worth thinking about repl eval. Only having one websocket and one client connection can be a big win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants