Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten up file reloading #5

Open
martinklepsch opened this issue Dec 10, 2014 · 3 comments
Open

Tighten up file reloading #5

martinklepsch opened this issue Dec 10, 2014 · 3 comments

Comments

@martinklepsch
Copy link
Contributor

As discovered in #2 sometimes files have not been reloaded even though they changed on disk. #4 has been an easy fix for this but isn't 100% exact. Imagine the following html:

<!doctype html>
<html>
  <head>
    <title>hi, world!</title>
    <link rel="stylesheet" href="main.css" type="text/css">
    <link rel="stylesheet" href="//some.cdn.com/framework/main.css" type="text/css">
  </head>
  <body>
    <script type="text/javascript" src="js/app.js"></script>
  </body>
</html>

Whenever main.css changes all other stylesheets ending in main.css will also be reloaded. It's probably not problematic in most cases but it'd be nice to get 100% exact reloading.
@myguidingstar-zz
Copy link

what about specifying boot-reload's argument list of in-project path to URI path rules, something like:

(boot-reload :uri-rules {"target/public" "", "resources/foo" "bar"})

which mean a file with this in-project path public/css/garden.css should have URI /css/garden.css; while resources/foo/script.js would be served as localhost:port/bar/script.js

@Deraen
Copy link
Contributor

Deraen commented Jul 3, 2015

@myguidingstar resources would be in :resources-paths meaning that boot-reload will never see the resources part of the path.

Also, :asset-path option was already added and I'm thinking it's good idea to keep all the local resources in one path (e.g. public: public/css/garden.css and public/foo/script.js).

@Deraen
Copy link
Contributor

Deraen commented Dec 21, 2016

Still managed to reproduce this.

(include-css "css/main.css")
(include-css "css/css/main.css")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinklepsch @Deraen @myguidingstar-zz