Skip to content

Commit

Permalink
Add internal remarks concerning "core" bootstrappers
Browse files Browse the repository at this point in the history
Hmm... this needs to be addressed, or it can become a serious issue!
  • Loading branch information
aedart committed Sep 28, 2024
1 parent 101f61f commit 11ab585
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/core/src/Application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,12 @@ export default class Application extends Container implements ApplicationContrac
*/
public get coreBootstrappers(): BootstrapperConstructor[]
{
// TODO: Ah... this can cause a side effect if multiple application instances are
// TODO: instantiated and bootstrapped, e.g. the Facade's container application will
// TODO: be overwritten!!!
// TODO: This needs to be changed somehow, such that ONLY the singleton instance
// TODO: automatically uses these "core" bootstrappers.

return [
LoadEnvironmentVariables,
SetupFacades
Expand Down

0 comments on commit 11ab585

Please sign in to comment.