Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging #103

Open
richardcantwell opened this issue Sep 3, 2020 · 3 comments
Open

Tagging #103

richardcantwell opened this issue Sep 3, 2020 · 3 comments

Comments

@richardcantwell
Copy link

Can you add the ability to add tags?

@simonkuran
Copy link

Do you mean the ability to add tags without overriding the current tags? I think that would be a very useful addition. Right now it's really awkward to have to query the current tags and merge them with the tags I'd like to add. I feel like line 810 of MailchimpSubscribeService.php should be moved to it's own service. Maybe to a service like removeTag or removeAllTags.

@bleepsandblops
Copy link

For anyone else finding this, if you change line

$tagsMap[$tag->name] = 'inactive';
to
$tagsMap[$tag->name] = 'active';
it adds your tag to the existing ones

@qrazi
Copy link

qrazi commented Apr 16, 2021

I want the same thing. Can't change the service, as we're using composer. Not sure yet if I'll fork this repo or proxy the service.

I think a good approach for this would be to add a hidden field to a form that allows signaling to the plugin what approach to take. So for instance:

<!--
 Indicate any tags not posted by this form should be removed.
This would also be the default value, making this hidden input optional
 -->
<input type="hidden" value="set" name="tags_method">

<!-- OR -->

<!-- Indicate should be added -->
<input type="hidden" value="merge" name="tags_method">

Reason for using hidden input vs config; this way allows per form configuration instead of per site configuration.

Would there be an interest in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants