Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_cc unrealistic values in longitudes greater than 90 #17

Open
danielmerbet opened this issue Nov 11, 2022 · 0 comments
Open

calc_cc unrealistic values in longitudes greater than 90 #17

danielmerbet opened this issue Nov 11, 2022 · 0 comments

Comments

@danielmerbet
Copy link

Hello,

I was doing some tests using this function to calculate cc at a point close to Indonesia, and I noticed some unrealistic values for times of sunrise and sunset (tsu and tss). I corrected the wrong values by changing line 42 of the function, it should be "std.mer = seq(-180,180, 15)", and not -90 to 90. I think this solves the issue, but correct me if I am wrong. I can create a pull request from a fork, just let me know.

regards,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant