Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH,MNT] Adding Init saving for deep clustering module #1903

Closed
hadifawaz1999 opened this issue Aug 4, 2024 · 9 comments · Fixed by #2359
Closed

[ENH,MNT] Adding Init saving for deep clustering module #1903

hadifawaz1999 opened this issue Aug 4, 2024 · 9 comments · Fixed by #2359
Assignees
Labels
clustering Clustering package deep learning Deep learning related enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request

Comments

@hadifawaz1999
Copy link
Member

Describe the feature or idea you want to propose

Following the updates in #1826 , would be nice to have the same functionality and testing in the deep clustering module.

Describe your proposed solution

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@hadifawaz1999 hadifawaz1999 added enhancement New feature, improvement request or other non-bug code enhancement clustering Clustering package testing Testing related issue or pull request deep learning Deep learning related labels Aug 4, 2024
@ghost
Copy link

ghost commented Aug 14, 2024

Hi! I'd like to work on this.

@ghost
Copy link

ghost commented Aug 14, 2024

Aeon-Assign bot assign @neuron283

@hadifawaz1999 hadifawaz1999 assigned ghost Aug 14, 2024
@ghost
Copy link

ghost commented Aug 14, 2024

@hadifawaz1999 Where should I add the testing function for deep clustering?
Under tests subdirectory there are 2 files: test_deep_clusterer_base.py and test_random_state_deep_learning_cluster.py

@ghost
Copy link

ghost commented Aug 14, 2024

Also, the tests for classification and regression mentioned in #1826 are missing from latest version of aeon. It's a little confusing. Can you please elaborate?

@hadifawaz1999
Copy link
Member Author

the tests were moved into a new directory recently, @MatthewMiddlehurst could you give us an idea to where the new tests should go after the revamp we got in ?

@MatthewMiddlehurst
Copy link
Member

If you want the test to run for each individual estimator, see the relevant yield file in testing/estimator_checking/. You will want to add a check there (or look at the functions there currently if just viewing).

Currently, clustering is being ported here #1877.

@ghost
Copy link

ghost commented Aug 15, 2024

should I wait before clustering gets ported or just carry on and create a PR?

@hadifawaz1999
Copy link
Member Author

should I wait before clustering gets ported or just carry on and create a PR?

probably will be simpler i think yes

@hadifawaz1999
Copy link
Member Author

closing as completed in #2359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clustering Clustering package deep learning Deep learning related enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request
Projects
None yet
2 participants