Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Split RocketClassifier and RocketRegressor into multiple classes #2089

Closed
6 tasks
MatthewMiddlehurst opened this issue Sep 24, 2024 · 3 comments · Fixed by #2207
Closed
6 tasks

[ENH] Split RocketClassifier and RocketRegressor into multiple classes #2089

MatthewMiddlehurst opened this issue Sep 24, 2024 · 3 comments · Fixed by #2207
Assignees
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package

Comments

@MatthewMiddlehurst
Copy link
Member

Describe the feature or idea you want to propose

Currently, Rocket, Mini-Rocket and Multi-Rocket are condensed into a single estimator. This is not very consistent with other files we have for similar algorithms i.e. SAST/RSAST, WEASEL/WEASELV2/MUSE etc.

Describe your proposed solution

Split RocketClassifier and RocketRegressor into:

  • RocketClassifier
  • MiniRocketClassifier
  • MultiRocketClassifier
  • RocketRegressor
  • MiniRocketRegressor
  • MultiRocketRegressor

Describe alternatives you've considered, if relevant

There is an argument to be made that we should condense these similar algorithms into a single class instead, but this is simpler for now.

Additional context

No response

@MatthewMiddlehurst MatthewMiddlehurst added enhancement New feature, improvement request or other non-bug code enhancement good first issue Good for newcomers classification Classification package regression Regression package labels Sep 24, 2024
@TonyBagnall
Copy link
Contributor

not sure about this, and what about hydra/multirocket hydra?

@TonyBagnall
Copy link
Contributor

the alternative is to go the other way, encapsulate SAST/RSAST, WEASEL, HIVE-COTE etc into single configurable classifiers. One to discuss at the next classification/regression dev meeting

@MatthewMiddlehurst MatthewMiddlehurst removed the good first issue Good for newcomers label Sep 24, 2024
@MatthewMiddlehurst
Copy link
Member Author

Hydra and MRH are already separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants