Skip to content

[ENH] remove non deterministic false tag from RDST #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

TonyBagnall
Copy link
Contributor

seeing if we can remove this tag now, see #324

@TonyBagnall TonyBagnall added classification Classification package full pytest actions Run the full pytest suite on a PR codecov actions Run the codecov action on a PR labels Oct 6, 2024
@TonyBagnall TonyBagnall requested a review from baraline October 6, 2024 16:14
@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Oct 6, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Oct 6, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@TonyBagnall TonyBagnall marked this pull request as draft October 6, 2024 16:17
@baraline
Copy link
Member

baraline commented Oct 6, 2024

Think we need to add it to the expected result test pipeline too. I'm afraid we'll have the same issue as with the regressor tho. Somehting in the transformer (numba) is surely causing this but I really don't know what it could be.

@TonyBagnall TonyBagnall removed the codecov actions Run the codecov action on a PR label Oct 6, 2024
@aeon-actions-bot aeon-actions-bot bot removed the full pytest actions Run the full pytest suite on a PR label Oct 6, 2024
@TonyBagnall TonyBagnall reopened this Nov 1, 2024
@TonyBagnall TonyBagnall added the codecov actions Run the codecov action on a PR label Nov 1, 2024
@aeon-actions-bot aeon-actions-bot bot removed the codecov actions Run the codecov action on a PR label Nov 1, 2024
@TonyBagnall TonyBagnall closed this Nov 1, 2024
@TonyBagnall TonyBagnall deleted the ajb/rdst branch April 11, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants