-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Distance module refactor part 2 #2178
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, new structure makes it alot cleaner and removes these long list of if else. Nice job ! Not approving yet as I can't view Matthew's link from phone.
Removed - it was a leftover note to self to test it (which it now has been)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will break everything unless the numba cache's are update so will merge close to midnight |
Reference Issues/PRs
#2161 #2170
What does this implement/fix? Explain your changes.
This PR is part 2 of cleaning up this distance module. This PR focuses on moving the remaining distances to an appropriate directory and cleaning up the code now that pairwise_distance is no longer a numba function (can use kwargs).
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
Some tests are disabled for the min distances and their coverage is lower than the others. This will be addressed in the distance module cleanup part 3.
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access