Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Distance module refactor part 2 #2178

Merged
merged 26 commits into from
Oct 30, 2024
Merged

[MNT] Distance module refactor part 2 #2178

merged 26 commits into from
Oct 30, 2024

Conversation

chrisholder
Copy link
Contributor

@chrisholder chrisholder commented Oct 11, 2024

Reference Issues/PRs

#2161 #2170

What does this implement/fix? Explain your changes.

This PR is part 2 of cleaning up this distance module. This PR focuses on moving the remaining distances to an appropriate directory and cleaning up the code now that pairwise_distance is no longer a numba function (can use kwargs).

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

Some tests are disabled for the min distances and their coverage is lower than the others. This will be addressed in the distance module cleanup part 3.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@chrisholder chrisholder added the codecov actions Run the codecov action on a PR label Oct 11, 2024
@aeon-actions-bot aeon-actions-bot bot added distances Distances package maintenance Continuous integration, unit testing & package distribution labels Oct 11, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Oct 11, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#5209C9}{\textsf{distances}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@chrisholder chrisholder added the no numba cache Disable numba cache loading on a PR label Oct 18, 2024
@chrisholder chrisholder removed the no numba cache Disable numba cache loading on a PR label Oct 19, 2024
@chrisholder chrisholder marked this pull request as ready for review October 19, 2024 09:52
@chrisholder chrisholder added the no numba cache Disable numba cache loading on a PR label Oct 19, 2024
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, new structure makes it alot cleaner and removes these long list of if else. Nice job ! Not approving yet as I can't view Matthew's link from phone.

@chrisholder
Copy link
Contributor Author

Is this still relevant? https://github.com/aeon-toolkit/aeon/pull/2170/files#diff-01a85f7ce36af292445124118eeab7646bc1de533efe47b579a7c2d67280df73R379

Removed - it was a leftover note to self to test it (which it now has been)!

@aeon-actions-bot aeon-actions-bot bot removed the codecov actions Run the codecov action on a PR label Oct 24, 2024
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeon-actions-bot aeon-actions-bot bot removed the no numba cache Disable numba cache loading on a PR label Oct 24, 2024
@chrisholder chrisholder added the no numba cache Disable numba cache loading on a PR label Oct 29, 2024
@aeon-actions-bot aeon-actions-bot bot removed the no numba cache Disable numba cache loading on a PR label Oct 29, 2024
@chrisholder chrisholder added the no numba cache Disable numba cache loading on a PR label Oct 29, 2024
@chrisholder
Copy link
Contributor Author

This PR will break everything unless the numba cache's are update so will merge close to midnight

@chrisholder chrisholder merged commit b049532 into main Oct 30, 2024
15 checks passed
@chrisholder chrisholder deleted the dist-module-cont branch October 30, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distances Distances package maintenance Continuous integration, unit testing & package distribution no numba cache Disable numba cache loading on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants