-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented COPOD for anomaly detection #2202
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. Thank you again!
I still think that the tests are excessive because we already test all cases with the PyODAdapter
. Could you boil it down to a couple of tests specific for the COPOD
-estimator? In addition, the current tests still refer to iforest
😉
@CodeLionX I am not familiar with COPOD algorithm. Could you please give an idea what kind of tests are required? |
I trust that the implementation in PyOD is correct. So, our tests would check that we integrate it in aeon correctly:
|
* add paper * add paper
…olkit#2204) * add WEASEL v2 paper * add ECML challenge
* registry refactor * all_estimators * comments and qc * fixes * fixes * exclude sklearn in docs * examples * examples
* numpy 2 * Update pyproject.toml * bound * scipy bound * correct method * not 2.1.0 * comment deps * comment deps * comment deps * make numpy 2.0 compatible * restore current numpy bound * revert to main pyproject * Empty commit for CI --------- Co-authored-by: aadya940 <[email protected]> Co-authored-by: Tony Bagnall <[email protected]> Co-authored-by: Tony Bagnall <[email protected]> Co-authored-by: TonyBagnall <[email protected]>
* split up rocket * test params * test params * test params
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Umm... sorry I was trying to rebase the branch and something wild happened 😅. Should I close this PR and open a new one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some minor changes so that we don't need to clean it up later 👍🏼
great, thanks for this |
Reference Issues/PRs
Fixes #2111
What does this implement/fix? Explain your changes.
Implements COPOD from PyOD to be used in aeon framework along with some test cases.
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access