feat: unwrap errors

Formerly the otelgqlgen reports always the errors' type is gqlerror.Error,
but now it reports the underlying errors' type.

Author: aereal

test/resolvers/main.resolvers.go

@@ -5,3 +5,9 @@ package resolvers
 // It serves as dependency injection for your app, add any dependencies you require here.
 
 type Resolver struct{}
+
+type ForbiddenError struct{}
+
+func (ForbiddenError) Error() string {
+	return "forbidden"
+}

test/resolvers/resolver.go

@@ -285,8 +285,8 @@ func TestTracer(t *testing.T) {
 							Name: semconv.ExceptionEventName,
 							Attributes: []attribute.KeyValue{
 								attribute.String("graphql.errors.path", "user"),
-								semconv.ExceptionTypeKey.String("*gqlerror.Error"),
-								semconv.ExceptionMessageKey.String("input: user forbidden"),
+								semconv.ExceptionTypeKey.String("github.com/aereal/otelgqlgen/test/resolvers.ForbiddenError"),
+								semconv.ExceptionMessageKey.String("forbidden"),
 								attrStacktrace,
 							},
 						},
@@ -301,8 +301,8 @@ func TestTracer(t *testing.T) {
 							Name: semconv.ExceptionEventName,
 							Attributes: []attribute.KeyValue{
 								attribute.String("graphql.errors.path", "user"),
-								semconv.ExceptionTypeKey.String("*gqlerror.Error"),
-								semconv.ExceptionMessageKey.String("input: user forbidden"),
+								semconv.ExceptionTypeKey.String("github.com/aereal/otelgqlgen/test/resolvers.ForbiddenError"),
+								semconv.ExceptionMessageKey.String("forbidden"),
 								attrStacktrace,
 							},
 						},
@@ -372,17 +372,17 @@ func TestTracer(t *testing.T) {
 							Name: semconv.ExceptionEventName,
 							Attributes: []attribute.KeyValue{
 								attribute.String("graphql.errors.path", "user.name"),
-								semconv.ExceptionTypeKey.String("*gqlerror.Error"),
-								semconv.ExceptionMessageKey.String("input: user.name invalid name"),
+								semconv.ExceptionTypeKey.String("*errors.errorString"),
+								semconv.ExceptionMessageKey.String("invalid name"),
 								attrStacktrace,
 							},
 						},
 						{
 							Name: semconv.ExceptionEventName,
 							Attributes: []attribute.KeyValue{
 								attribute.String("graphql.errors.path", "user.age"),
-								semconv.ExceptionTypeKey.String("*gqlerror.Error"),
-								semconv.ExceptionMessageKey.String("input: user.age invalid age"),
+								semconv.ExceptionTypeKey.String("*errors.errorString"),
+								semconv.ExceptionMessageKey.String("invalid age"),
 								attrStacktrace,
 							},
 						},
@@ -397,17 +397,17 @@ func TestTracer(t *testing.T) {
 							Name: semconv.ExceptionEventName,
 							Attributes: []attribute.KeyValue{
 								attribute.String("graphql.errors.path", "user.name"),
-								semconv.ExceptionTypeKey.String("*gqlerror.Error"),
-								semconv.ExceptionMessageKey.String("input: user.name invalid name"),
+								semconv.ExceptionTypeKey.String("*errors.errorString"),
+								semconv.ExceptionMessageKey.String("invalid name"),
 								attrStacktrace,
 							},
 						},
 						{
 							Name: semconv.ExceptionEventName,
 							Attributes: []attribute.KeyValue{
 								attribute.String("graphql.errors.path", "user.age"),
-								semconv.ExceptionTypeKey.String("*gqlerror.Error"),
-								semconv.ExceptionMessageKey.String("input: user.age invalid age"),
+								semconv.ExceptionTypeKey.String("*errors.errorString"),
+								semconv.ExceptionMessageKey.String("invalid age"),
 								attrStacktrace,
 							},
 						},

test/tracer_test.go

@@ -229,7 +229,23 @@ func recordGQLErrors(span trace.Span, errs gqlerror.List) {
 		attrs := []attribute.KeyValue{
 			keyErrorPath.String(e.Path.String()),
 		}
-		span.RecordError(e, trace.WithStackTrace(true), trace.WithAttributes(attrs...))
+		err := unwrapErr(e)
+		span.RecordError(err, trace.WithStackTrace(true), trace.WithAttributes(attrs...))
+	}
+}
+
+func unwrapErr(err error) error {
+	var underlying error = err
+	for {
+		wrapped, ok := underlying.(interface{ Unwrap() error })
+		if !ok {
+			return underlying
+		}
+		unwrapped := wrapped.Unwrap()
+		if unwrapped == nil {
+			return underlying
+		}
+		underlying = unwrapped
 	}
 }