You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The url produced by the SDK is. https://api.aerisapi.com/forecasts/55455?client_id=<client_id>&client_secret=<client_secret>&fields=periods.avgTempF,periods.validTime,periods.precipIN&filter=#hr,
It's easy enough for SDK consumers to write our own Enums to pass to the filter_ parameter however the trailing , still causes the filter value to be invalid.
Thanks for the bug report. Pull request #2 has been merged. As I mentioned in a comment there, it is my intent to revamp the Python SDK at some point in the future. I am aware that there are a few bits of the current Python SDK that aren't working quite right, and it could do with some cleanup in general.
I will leave this open as a reminder that this specific bug should be reviewed when the Python SDK is improved.
RequestFilter.FORECASTS.HR
produces the value'#hr'
which is the name of a filter but not an accepted value.For example if I create a request using the Python SDK.
The url produced by the SDK is.
https://api.aerisapi.com/forecasts/55455?client_id=<client_id>&client_secret=<client_secret>&fields=periods.avgTempF,periods.validTime,periods.precipIN&filter=#hr,
It's easy enough for SDK consumers to write our own Enums to pass to the filter_ parameter however the trailing
,
still causes the filter value to be invalid.The trailing comma issue is shown in this pull-request by bkurtz
The text was updated successfully, but these errors were encountered: