Skip to content

Commit aae3e02

Browse files
authored
Merge pull request #79 from pb82/asb-compat-fix
dont require service binding id
2 parents ff346ff + 799ef70 commit aae3e02

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ OiBpb3NJc1Byb2R1Y3Rpb24KICAgICAgdGl0bGU6IElzIHRoaXMgYSBwcm9kdWN0aW9uIGNlcnRp\
4343
ZmljYXRlPwogICAgICBkZWZhdWx0OiBmYWxzZQogICAgICB0eXBlOiBib29sZWFuCiAgICAgIGRp\
4444
c3BsYXlfdHlwZTogY2hlY2tib3gKICAgICAgZGlzcGxheV9ncm91cDogaU9TCg=="
4545

46+
4647
COPY playbooks /opt/apb/actions
4748
COPY roles /opt/ansible/roles
4849
COPY vars /opt/ansible/vars

roles/bind-unifiedpush-apb/tasks/main.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
# Store the name of the service instance. It's required for some purposes like adding
22
# annotations to the mobile client
33

4-
- name: "Get the name of the service insance"
4+
- name: "Get the name of the service instance"
55
shell: oc get serviceinstance --namespace={{ namespace }} -o jsonpath='{.items[?(@.spec.externalID=="{{ _apb_service_instance_id }}")].metadata.name}'
66
register: serviceinstance_name
77

8+
- name: "Ensure compatibility with older ASB versions"
9+
set_fact:
10+
_apb_service_binding_id: "DUMMY"
11+
when: _apb_service_binding_id is not defined
12+
813
- set_fact:
914
UPS_NAME: "{{ serviceinstance_name.stdout }}"
1015

roles/provision-unifiedpush-apb/tasks/provision-ups.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
until: ups_result.stdout.find("3") != -1
119119
retries: 30
120120
delay: 5
121-
121+
122122
- name: "Create {{ namespace }} PushApplication on service host {{ unifiedpush_service.service.spec.cluster_ip }}"
123123
uri:
124124
url: "http://{{ unifiedpush_service.service.spec.cluster_ip }}/rest/applications"
@@ -127,7 +127,7 @@
127127
validate_certs: no
128128
body_format: json
129129
status_code: 201
130-
retries: 5
130+
retries: 30
131131
until: namespace_push_app.status == 201
132132
delay: 5
133133
register: namespace_push_app

0 commit comments

Comments
 (0)