Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 word coolnames are not cool #118

Open
thclark opened this issue Mar 15, 2023 · 1 comment
Open

5 word coolnames are not cool #118

thclark opened this issue Mar 15, 2023 · 1 comment

Comments

@thclark
Copy link
Contributor

thclark commented Mar 15, 2023

Feature request

The measurement campaign reference is set automatically using a coolname if it's not set in the configuration. It's not at all obvious what this is for, and it's undocumented. What differentiates this from the label field??

Also, long coolnames are a pain. If it has to be a coolname, just two words will give a more easily searchable and less weird-and-esoteric value whilst remaining sufficiently unique

Suggested improvement

  • Change the coolname to two elements
  • Provide documentation describing what a measurement campaign actually is
@time-trader
Copy link
Contributor

time-trader commented Mar 20, 2023

As discussed before, the goal to introduce "measurement campaign" concept for easier data retrieval/filtering. Essentially it is similar to "installation", depending on how you define installation. It is surely possible to get a table that contains information similar to the "measuremnt campaign" one using the following query on sensor data:

SELECT installation_reference, min(datetime) as start, max(datetime) as finish, node_id, sensor_type_reference FROM `aerosense-twined.greta.sensor_data`
GROUP BY installation_reference, node_id, sensor_type_reference

Now, whether "measurement campaign" is sufficiently narrower than the "installation" to warrant it's own existence, is a separate topic. But the idea is to have additional metadata, particularly: "On a specific installation, what nodes and sensor were active during certain period of time and for what purpose ?"
I guess the question is "what should be the "primary key" (not entirely correct term, but you get the idea) to get the desired data series?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants