Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determination of version information from software build system #14

Open
elfring opened this issue Feb 8, 2019 · 3 comments
Open

Determination of version information from software build system #14

elfring opened this issue Feb 8, 2019 · 3 comments

Comments

@elfring
Copy link

elfring commented Feb 8, 2019

Software build systems can provide version information in a structured way.
I suggest to use these data so that related details like a specific macro will be automatically constructed.
@aesophor
Copy link
Owner

aesophor commented Feb 11, 2019 •
edited
Loading

In 83690cb and 5df8796, I used this technique and implemented conditional compilation and linking, which makes building this project from source much easier (as glog is only optional from now on).

Also, I'm not sure if I should make other macros automatically generated by CMake as well? Or should I just leave them be?

Thank you so much for spending your time on helping me improve this project 😄

elfring referenced this issue Feb 11, 2019
@aesophor
conditionally link glog.
83690cb 
Previously, glog is a required to compile and link Wmderland.

Now CMake can detect if glog is installed in your system and decide
whether to link glog or not.
@elfring
Copy link
Author

elfring commented Feb 11, 2019

Further software adjustments will be helpful at some places.

@aesophor
Copy link
Owner

Thank you! I have corrected them in fb2198f

  • Version variables are moved into project() and replaced with @PROJECT_VERSION@
  • WIN_MGR_NAME are generated with @PROJECT_NAME@
  • Removed REQUIRED from find_package(glog)
  • config.hpp will now be generated in the binary directory (build/). I've made sure the conditional compilation and linking still works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @aesophor